-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake Presets #1207
Comments
Thanks for posting! It might take a while before we look at your issue, so don't worry if there seems to be no feedback. We'll get to it. |
@sweemer I love the idea. Separating out the details of a cmake config into a named preset is a great way to go. |
Thanks! Feel free to create a PR. |
Glad to hear you like the idea. I've submitted a draft PR #1209 and will mark it as ready for review once all the tests successfully pass. Would you be able to approve the test workflows for me? |
I saw that there was recently a large overhaul to the CMake build system by @pkovacs in #1183, which looks nice.
One thing it doesn't include however is CMake Presets, which I have found to be very useful in configuring builds for multiple platforms and IDEs.
I would like to add a simple
CMakePresets.json
file that covers a few common configurations such as Linux, Windows, Debug, Release, etc, and which other users can build upon for other configurations, either directly inCMakePresets.json
or in their ownCMakeUserPresets.json
.As this is the first issue I have created in this repository, I'd first like to ask, are there any comments or concerns before I submit a pull request for this new feature?
The text was updated successfully, but these errors were encountered: