Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake Presets #1207

Closed
sweemer opened this issue Oct 11, 2021 · 4 comments · Fixed by #1209
Closed

Add CMake Presets #1207

sweemer opened this issue Oct 11, 2021 · 4 comments · Fixed by #1209

Comments

@sweemer
Copy link
Contributor

sweemer commented Oct 11, 2021

I saw that there was recently a large overhaul to the CMake build system by @pkovacs in #1183, which looks nice.

One thing it doesn't include however is CMake Presets, which I have found to be very useful in configuring builds for multiple platforms and IDEs.

I would like to add a simple CMakePresets.json file that covers a few common configurations such as Linux, Windows, Debug, Release, etc, and which other users can build upon for other configurations, either directly in CMakePresets.json or in their own CMakeUserPresets.json.

As this is the first issue I have created in this repository, I'd first like to ask, are there any comments or concerns before I submit a pull request for this new feature?

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 11, 2021

Thanks for posting! It might take a while before we look at your issue, so don't worry if there seems to be no feedback. We'll get to it.

@pkovacs
Copy link
Contributor

pkovacs commented Oct 11, 2021

@sweemer I love the idea. Separating out the details of a cmake config into a named preset is a great way to go.

@lballabio
Copy link
Owner

Thanks! Feel free to create a PR.

@sweemer
Copy link
Contributor Author

sweemer commented Oct 11, 2021

Glad to hear you like the idea. I've submitted a draft PR #1209 and will mark it as ready for review once all the tests successfully pass. Would you be able to approve the test workflows for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants