Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded with empty "type" #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boekkooi-fresh
Copy link

This PR fixes a issue where something like frame.contentWindow.postMessage({ id: "docson", action: "load", definitions: definition, type: ""}, "*"); was not working.

@yanick
Copy link
Collaborator

yanick commented Feb 3, 2018

Can you provide a case where type would be legitimately set to the empty string? I'm trying to figure out in which cases it could happen, and what is the desired behavior in those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants