Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking protocol version #3739

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Fix checking protocol version #3739

merged 7 commits into from
Aug 2, 2024

Conversation

ben221199
Copy link
Contributor

This pull request fixes issue #3738.

@ben221199
Copy link
Contributor Author

In addition, the code was added by @jackrobison in 1bf51e8.

@ben221199
Copy link
Contributor Author

The commit was made after tagging v0.53.2, so the bug got released in v0.53.3.

If someone wants to write a LBRY hub themselves, note that v0.53.2 doesn't have the bug, v0.53.3 to v0.113.0 have the bug, and if this pull request gets tagged as v0.114.0, from that version onwards the bug should be fixed.

@ben221199
Copy link
Contributor Author

Hi @shyba, can you rerun the workflows again from here? It seemed they stopped and even disappeared.

@coveralls
Copy link

Coverage Status

coverage: 56.987% (-0.1%) from 57.083%
when pulling 191627e on ben221199:master
into eb5da95 on lbryio:master.

@ben221199
Copy link
Contributor Author

Merge please 🙂

@shyba shyba merged commit e7666f4 into lbryio:master Aug 2, 2024
15 of 16 checks passed
@ben221199
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants