Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 7.4] Versioning of ext-json #31

Closed
carusogabriel opened this issue Oct 30, 2019 · 4 comments · Fixed by #32
Closed

[PHP 7.4] Versioning of ext-json #31

carusogabriel opened this issue Oct 30, 2019 · 4 comments · Fixed by #32
Labels
Improvement Improvement of existing feature
Milestone

Comments

@carusogabriel
Copy link
Contributor

carusogabriel commented Oct 30, 2019

Up to PHP 7.3, the json extension used to follow its own versioning.

Now, in PHP 7.4+, it is following the same as other extensions: PHP's version number:

For reference: php/php-src#4459

@lcobucci How can we solve this? Adding || ^7.4 or replacing it with * when declaring ext-json in the requirements of Composer?

@lcobucci lcobucci added this to the 2.1.0 milestone Oct 30, 2019
@lcobucci lcobucci added the Improvement Improvement of existing feature label Oct 30, 2019
@lcobucci
Copy link
Owner

I think that having ^1.7 || ^7.4 for ext-json makes more sense than *.
With that, we should solve PHP 7.4 compatibility and be able to disallow failures for 7.4snapshot.

For v2.2 we should just require PHP 7.4+ IMHO.

Does this make sense to you?

@carusogabriel
Copy link
Contributor Author

@lcobucci Yeah, it does 👍

I'll open the PR.

@nikic
Copy link

nikic commented Oct 30, 2019

I'd recommend always specifying builtin extensions as *, because these are always tightly bound to the PHP version. You need to change the PHP version requirement as a whole if you want to change a builtin extension requirement.

@lcobucci
Copy link
Owner

That's a good point @nikic. I'm fine with * for builtin extensions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants