Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return frequency of name for country #1

Open
realRandomWalk opened this issue Mar 17, 2016 · 3 comments
Open

Return frequency of name for country #1

realRandomWalk opened this issue Mar 17, 2016 · 3 comments

Comments

@realRandomWalk
Copy link

In the nam_dict.txt there is data on relative frequency of names in a given country. I'd propose to add a feature to optionally return the frequency as well.

From nam_dict.txt:

Frequencies of first names are indicated as single-digit hexadecimal numbers ranging from 1 (= rare) to D (=13) (= extremely common) for the following countries...

In some cases, knowing that a name is a rare or common for males and/or females is relevant rather than just the ratio. If there is interest, I would be willing to code the feature. I just wanted to get feedback to see if such a feature would be of interest and ultimately merged.

@dukebody
Copy link

I find that interesting! Please:

  • Write automated tests for the new feature.
  • Respect the current behaviour, i.e. current code using the library with current functionality must work without modifications.

Thanks!

@realRandomWalk
Copy link
Author

Great. Can't promise quick turn around. Will try to take a look at it this weekend.

@dukebody
Copy link

Any progress here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants