Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a mistake in shuffle_minibatch function #3

Open
tmdrn9 opened this issue Apr 20, 2022 · 0 comments
Open

There is a mistake in shuffle_minibatch function #3

tmdrn9 opened this issue Apr 20, 2022 · 0 comments

Comments

@tmdrn9
Copy link

tmdrn9 commented Apr 20, 2022

Hello.
Thank you for your share.

First of all, My English is not so fluent.
Please understand it.

There is a mistake in shuffle_minibatch function in main_cifar10.py, main_cifar100.py

def shuffle_minibatch(inputs, targets, n_class=88, mixup=True):
    """Shuffle a minibatch and do linear interpolation between images and labels.
    Args:
        inputs: a numpy array of images with size batch_size x H x W x 3.
        targets: a numpy array of labels with size batch_size x 1.
        mixup: a boolen as whether to do mixup or not. If mixup is True, we
            sample the weight from beta distribution using parameter alpha=1,
            beta=1. If mixup is False, we set the weight to be 1 and 0
            respectively for the randomly shuffled mini-batches.
    """

According to your comment, inputs parameter shape is batch_size x H x W x 3.
but your input shape is batch_sizex 3 x H x W, isn't it?

I think you change comment

Thank you for your work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant