-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test is marked Pass, when Canopy assertion "==" fails and returns error #310
Comments
The test did not pass, the two above it did. It is still white which makes me think that the runner has not marked it as failed yet, or that there is a bug in the reporter. Can you set it up to run just these three tests and see how it behaves? Do the values in the console look different than the html report? |
Ok that failure is different than the failure in your first screenshot. Did this cause the html report to show a failure correctly? Either way I will look at it this afternoon and try to reproduce or determine what could be the problem. Fortunately fixing bugs in the reporter does not require you to make any changes on your end. |
My bad, I added the wrong screen-shot, so I Re-run the exact code from above and attached the correct screen-shot. |
ok thanks! |
I managed to reproduce it again, here is my report file: There must be some inconsistency, but not sure what. |
Using your zip, I run this in the console
Which is (minus some encoding) what canopy would run, and it marks it as red. The only thing that I can think of is that the it is doing 'swalloedjS' will which runn the js, but if it fails it will keep going, and it is failing once, but not consistently. Maybe I can make it retry. Let me try to repro and keep looking. |
I was able to repro so I am looking now. |
You can see this message in your console screenshot: [9004:7028:1117/164130:ERROR:http_connection.cc(37)] Too large read data is pending: capacity=1048576, max_buffer_size=1048576, read=1048576 When an error occurs canopy takes a screenshot of the image and then base64 encodes it and puts it in the report. When I take a screenshot of your site, its around 900k, and when encoded its 1.2 megs. It looks like chrome/chromedriver only allows a message of ~1 meg, which is too small for a screenshot of your size. For example on my test page which is really basic and just black and white text, its only 60k. I think its because your page has a city scape image which does not compress well because each pixel is relatively unique. You can resize the browser so that the image is smaller
Not really great per se but it works. You can also disable image injection, but images in your report is one of the most valuable features in my opinion.
It may be possible to send a flag to chrome to accept more data, but I don't have time to look into that right now, sorry. I hope this helps and gets your pointed in a good direction. |
I thought of one other solution. I may be able to convert the image from .png to .jpeg (which offers more compression) and that would solve it. I will look into that today. |
The screen-shots are very important and relevant for my reports. Please let me know, if the .png to .jpeg conversion is working fine. |
This is now fixed in canopy 1.0.4 which you can download here: https://www.nuget.org/packages/canopy/1.0.4 If you have any more problems please let me know. Thank you for reporting this bug! |
It's working great! Thank you, too, for looking into it and finding a very good fix! :) |
I am going to close this issue, if you have any more bugs/questions please feel free to open new issues! |
I am new to Canopy and F#, still trying to get my head around these.
In the following code, I just want a simple assertion "==" to make my test fail and mark it as Fail in the Reporter file.
For some reason, the test is Pass, although the error was thrown.
I tried other assertions too : "===", "!=" and same thing happens.
What am i missing? Please help me.
The text was updated successfully, but these errors were encountered: