From 3a6d74bd3940761ef3a1da896d0358dba9c90627 Mon Sep 17 00:00:00 2001
From: legends-killer <yyy@legends-killer.cq.cn>
Date: Thu, 18 Jan 2024 20:21:56 +0800
Subject: [PATCH] fix: dispose suggestion providers when component destroyed

---
 package.json             |  2 +-
 src/JsonEditor/index.tsx | 46 +++++++++++++++++++++++++---------------
 2 files changed, 30 insertions(+), 18 deletions(-)

diff --git a/package.json b/package.json
index 9842c4c..f6b4d5d 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yaje",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "author": "legends-killer <yyy@legends-killer.cq.cn>",
   "description": "yet another json editor",
   "keywords": [
diff --git a/src/JsonEditor/index.tsx b/src/JsonEditor/index.tsx
index f47b686..01f675e 100644
--- a/src/JsonEditor/index.tsx
+++ b/src/JsonEditor/index.tsx
@@ -2,14 +2,14 @@
  * @Author: legends-killer
  * @Date: 2023-12-27 18:47:08
  * @LastEditors: legends-killer
- * @LastEditTime: 2024-01-17 22:55:58
+ * @LastEditTime: 2024-01-18 20:19:15
  * @Description:
  */
 import { Editor, EditorProps, useMonaco } from '@monaco-editor/react'
-import { forwardRef, useEffect, useImperativeHandle, useState } from 'react'
+import { forwardRef, useEffect, useImperativeHandle } from 'react'
 import { refItemProvider } from './provider/refItemProvider'
 import { ISuggestionItem, JsonSchemaProcessor } from './helper/jsonSchemaProcessor'
-import { languages as Languages, IDisposable } from 'monaco-editor'
+import { IDisposable, languages as Languages } from 'monaco-editor'
 import { IProviderParam } from './provider/types'
 import { filterRepeateSuggestions } from './utils'
 
@@ -89,6 +89,7 @@ export const JsonEditor = forwardRef((props: IJsonEditor, ref: any) => {
 
   // init monaco
   useEffect(() => {
+    const providers: IDisposable[] = []
     if (monaco) {
       const jsonSchemaProcessor = new JsonSchemaProcessor(promptJsonSchema || {})
       const suggestions = jsonSchemaProcessor.getSuggestions()
@@ -111,22 +112,10 @@ export const JsonEditor = forwardRef((props: IJsonEditor, ref: any) => {
       })
 
       // default provider
-      monaco.languages.registerCompletionItemProvider(
-        'json',
-        refItemProvider({
-          monaco,
-          jsonKeySuggestions: finalKeySuggestions,
-          jsonValueSuggestions: finalValueSuggestions,
-          onSuggestionItemSelect,
-          triggerCharacters,
-        })
-      )
-
-      // users provider
-      userDefinedItemCompleteProviders.forEach((userProvider) => {
+      providers.push(
         monaco.languages.registerCompletionItemProvider(
           'json',
-          userProvider({
+          refItemProvider({
             monaco,
             jsonKeySuggestions: finalKeySuggestions,
             jsonValueSuggestions: finalValueSuggestions,
@@ -134,8 +123,31 @@ export const JsonEditor = forwardRef((props: IJsonEditor, ref: any) => {
             triggerCharacters,
           })
         )
+      )
+
+      // users provider
+      userDefinedItemCompleteProviders.forEach((userProvider) => {
+        providers.push(
+          monaco.languages.registerCompletionItemProvider(
+            'json',
+            userProvider({
+              monaco,
+              jsonKeySuggestions: finalKeySuggestions,
+              jsonValueSuggestions: finalValueSuggestions,
+              onSuggestionItemSelect,
+              triggerCharacters,
+            })
+          )
+        )
       })
     }
+    return () => {
+      if (monaco) {
+        providers.forEach((item) => {
+          item.dispose()
+        })
+      }
+    }
   }, [
     addedKeySuggestions,
     addedValueSuggestions,