Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leo_gateway][nfs] Uploading a big file may take too long #537

Closed
mocchira opened this issue Dec 9, 2016 · 1 comment
Closed

[leo_gateway][nfs] Uploading a big file may take too long #537

mocchira opened this issue Dec 9, 2016 · 1 comment

Comments

@mocchira
Copy link
Member

mocchira commented Dec 9, 2016

It turned out that
The more large size, the more head requests a leo_gateway issues to leo_storage(s).
The below code may cause this problem in case handling a very large file.
https://github.com/leo-project/leo_gateway/blob/1.3.0/src/leo_nfs_file_handler.erl#L456-L479

This can be solved decreasing the number of requests to leo_storage(s).
In order to realise the above requirement, we need to come up with another implementation to calculate the total file size after updating.

@mocchira mocchira added this to the 1.3.2 milestone Dec 9, 2016
@mocchira mocchira added Bug and removed survey labels Dec 13, 2016
@mocchira mocchira modified the milestones: 1.3.1, 1.3.2 Dec 13, 2016
@mocchira mocchira self-assigned this Dec 13, 2016
@mocchira
Copy link
Member Author

As the current implementation assumes a chunk size set to files is same with the one in leo_gateway.conf (see: #540 )
the total file size can be calculated using simple math.

chunk_size * (cnumber - 1) + dsize_of_last_chunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant