[leofs] To be able to correctly terminate leofs-adm's commads on Ubuntu-18.04 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocchira
requested changes
Apr 24, 2018
leofs-adm
Outdated
| @@ -67,6 +67,14 @@ case $OS in | |||
| SunOS) | |||
| NC_ARGS="" | |||
| ;; | |||
| Linux) | |||
| ## For Ubuntu-18.04 | |||
| if cat /etc/issue | grep -q 'Ubuntu Bionic'; then | |||
There was a problem hiding this comment.
/etc/issue can be modified by sysadmin so it would be better to use lsb_release to distinguish the distribution and its version like the following.
leofs@cat2neat$ lsb_release -is
Ubuntu
leofs@cat2neat$ lsb_release -rs
18.04
leofs@cat2neat:leo_object_storage$ lsb_release -irs
Ubuntu
18.04
|
@mocchira PTAL |
mocchira
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found
leofs-admcommands cannot terminate on Ubuntu-18.04.