Change the function validLib to improve the code efficiency. #255
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 71.93% 71.99% +0.06%
==========================================
Files 50 50
Lines 6477 6478 +1
Branches 940 940
==========================================
+ Hits 4659 4664 +5
+ Misses 1818 1814 -4 ☔ View full report in Codecov by Sentry. |
johannct
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
LGTM but we can push a bit forward :
- you mention a few other places where this could be done. It is the right place to do it
- zfix arg in validLib is not really sound. In photoz_lib zfix should be tested and validLib called only when zfix==true. Note that a vector with the first N integers is obtained with std::iota :
#include <numeric> std::vector<int> vec(fullLib.size()); // fills the vector from 1 to N std::iota(vec.begin(), vec.end(), 0); - a unit test is easy to build and should be done
- should we take this opportunity to write a notebook that shows the usefulness of running with zfix==yes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the function validLib in onesource.cpp. Rather than providing fullLib as an argument, I passed the redshift from the library. The price for manipulating the large vector of complex objects (fullLib) was slowing down the code. With this modification, we gain almost a factor 3 in speed when zfix=yes. Results are exactly the same. I think that such change could be done in few other functions.