Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTENT TO DEPRECATE] Remove support for IE8 and remove shimming code in Less #3114

Open
matthew-dean opened this issue Oct 10, 2017 · 9 comments

Comments

@matthew-dean
Copy link
Member

Any comments / opposition to dropping IE8 support?

Also, any reason to keep support for Node 0.12? Seems like Node 4+ is a suitable target now?

@matthew-dean
Copy link
Member Author

Related to: #3121

@stale
Copy link

stale bot commented Mar 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2018
@matthew-dean
Copy link
Member Author

Just to be clear, Less is now on 4+ and I'm changing this to something that should happen. Anything IE8-10 specific in the code base or tests should be removed.

@jfitzsimmons
Copy link

jfitzsimmons commented May 8, 2023

I was going to give this a go.

From what I can tell their is a Grunt command

`node bin/lessc --ie-compat ${lessFolder}/_main/lazy-eval.less tmp/lazy-eval.css`,

which currently the flag just warns of deprecation and nothing else

case 'ie-compat': console.warn('The --ie-compat option is deprecated, as it has no effect on compilation.'); break;

may be a few other Grunt tweaks.


the are also 2 tests around multiple Guards for ie8


and there is a detached ruleset for ie9 that is also used in the docs as an example for detached rulesets:
https://github.com/less/less-docs/blob/master/content/features/detached-rulesets.md

@matthew-dean
Copy link
Member Author

matthew-dean commented May 8, 2023

@jfitzsimmons On the test level, yes, but I meant there might be shims for Promises or other browser shims within the codebase itself that are now irrelevant. I can't remember if the browser shim was removed or not.

@jfitzsimmons
Copy link

@matthew-dean I'm not seeing anything jump out in the source. Do you have an example area of concern? or a rough idea of features that may have needed shimming?

Was the ie-compat plugin being used for shimming? #3446

@matthew-dean
Copy link
Member Author

@jfitzsimmons To be honest, I opened this in 2017, so I have no idea if I or someone else addressed this by now.

@SarveshChandnani
Copy link

is this bug still open to work on?

@iChenLei
Copy link
Member

Yes , @SarveshChandnani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants