Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support align incremental window #3399

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 25, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 71.62162% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (e795d19) to head (64bcb2d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_op.go 71.23% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   71.21%   71.18%   -0.04%     
==========================================
  Files         407      407              
  Lines       46661    46712      +51     
==========================================
+ Hits        33229    33248      +19     
- Misses      10834    10864      +30     
- Partials     2598     2600       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review November 26, 2024 06:19
@Yisaer Yisaer requested a review from ngjaying November 27, 2024 05:24
@ngjaying ngjaying merged commit 7cf3c6a into lf-edge:master Nov 27, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants