Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C benchmark PingPong is broken #1058

Closed
cmnrd opened this issue Mar 23, 2022 · 3 comments
Closed

C benchmark PingPong is broken #1058

cmnrd opened this issue Mar 23, 2022 · 3 comments
Labels
bug Something isn't working c Related to C target

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Mar 23, 2022

The C version of PingPong prints the following error message and returns with a non-zero exit code.

Pong expected to receive 1000000 inputs, but it received 12000000.

The benchmark implementation looks correct to me, and it used to work in the past. Therefore, I assume that there is a bug in the code generator and/or the c runtime.

@cmnrd cmnrd added bug Something isn't working c Related to C target labels Mar 23, 2022
@petervdonovan
Copy link
Collaborator

This is fixed in the benchmark-updates branch. It is a bug in the benchmark. I just didn't merge it because I figured that more problems would probably turn up.

@cmnrd
Copy link
Collaborator Author

cmnrd commented Mar 28, 2022

I see. Should we get this branch merged then? Do you want to open a PR?

@cmnrd
Copy link
Collaborator Author

cmnrd commented Apr 5, 2022

Closed by lf-lang/benchmarks-lingua-franca#3

@cmnrd cmnrd closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c Related to C target
Projects
None yet
Development

No branches or pull requests

2 participants