Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Lfc threading property to single-thread or non-threaded #1636

Closed
patilatharva opened this issue Mar 10, 2023 · 5 comments
Closed

Change Lfc threading property to single-thread or non-threaded #1636

patilatharva opened this issue Mar 10, 2023 · 5 comments
Labels
cli good first issue Good for newcomers

Comments

@patilatharva
Copy link
Collaborator

patilatharva commented Mar 10, 2023

Currently, the Lfc CLI has a --threading option which accepts a "true"/"false" value.
This is inconsistent with all of our other boolean options (e.g. --quiet, --clean), which don't require explicit arguments because they're false by default and become true when supplied.

The --threading option seems to be designed this way because unlike the other boolean options, we want it to be true by default:

// If the unthreaded runtime is not requested by the user, use the threaded runtime instead
// because it is the only one currently capable of handling asynchronous events.
if (!targetConfig.threading && !targetConfig.setByUser.contains(TargetProperty.THREADING)) {
targetConfig.threading = true;

I think it might be better if we changed it to something like --single-thread so it can be false by default, and users won't have to explicitly supply an argument for an otherwise boolean option. What are your thoughts?

--threading=false--single-thread or --non-threaded

@edwardalee
Copy link
Collaborator

This is a good idea. Maybe '--no-threads'.

@patilatharva patilatharva added good first issue Good for newcomers cli labels Mar 10, 2023
@lhstrh
Copy link
Member

lhstrh commented Mar 19, 2023

I also like --no-threads.

@lhstrh
Copy link
Member

lhstrh commented Mar 19, 2023

Alternatively, we could have --single-threaded. It is longer, but more technically correct...

@cmnrd
Copy link
Collaborator

cmnrd commented Feb 19, 2024

This one is already implemented, right? I think we should consider removing the old property for the 0.7.0 milestone and open a new issue to track this.

@cmnrd cmnrd added this to the 0.7.0 milestone Feb 19, 2024
@cmnrd
Copy link
Collaborator

cmnrd commented Feb 19, 2024

This was implemented in #1817

@cmnrd cmnrd closed this as completed Feb 19, 2024
@cmnrd cmnrd removed this from the 0.7.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants