-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Lfc threading
property to single-thread
or non-threaded
#1636
Labels
Comments
This is a good idea. Maybe '--no-threads'. |
I also like |
Alternatively, we could have |
This one is already implemented, right? I think we should consider removing the old property for the 0.7.0 milestone and open a new issue to track this. |
This was implemented in #1817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the Lfc CLI has a
--threading
option which accepts a "true"/"false" value.This is inconsistent with all of our other boolean options (e.g.
--quiet
,--clean
), which don't require explicit arguments because they'refalse
by default and becometrue
when supplied.The
--threading
option seems to be designed this way because unlike the other boolean options, we want it to betrue
by default:lingua-franca/org.lflang/src/org/lflang/generator/c/CGenerator.java
Lines 406 to 409 in 0e00a81
I think it might be better if we changed it to something like
--single-thread
so it can befalse
by default, and users won't have to explicitly supply an argument for an otherwise boolean option. What are your thoughts?--threading=false
→--single-thread
or--non-threaded
The text was updated successfully, but these errors were encountered: