Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ./bin and ./utils #1992

Closed
axmmisaka opened this issue Sep 7, 2023 · 6 comments
Closed

Remove ./bin and ./utils #1992

axmmisaka opened this issue Sep 7, 2023 · 6 comments
Labels
wontfix This will not be worked on

Comments

@axmmisaka
Copy link
Collaborator

This is from #1988

I am thinking removing all of them. Developers should know after building where the artifacts are, and handle PATH themselves should they wish to add these artifacts to their PATH. They should also run ./gradlew :cli:lfc:assemble at their pleasure. If they are not familiar with how to do so, using nightly would be a better idea.

After #1988 there would be a ton of stuff in ./bin. Yet (I think) these utility scropts doesn't really belong in this repo.

I have this feeling as some projects I've seen (like NSA's Ghidra) do this. Most projects don't have a script dedicated to help people execute the build process, rather they simply point developers to the right direction in README. I think we should do that, but that's my €0.02.

@axmmisaka
Copy link
Collaborator Author

One more reason:

PS: These scripts are kind of a PITA here; bash and pwsh are cross platform, but the scripts are assuming platform based on what people use; I say it's gradle's fault
lfc-dev won't work on MSysGit/git bash, and lfc-dev.ps1 won't work on linux pwsh.

@cmnrd
Copy link
Collaborator

cmnrd commented Sep 11, 2023

utils already got removed by #1995.

Personally, I find the bin scripts extremely useful. Not because I don't want to use gradle, but because I can run the script from anywhere in the filesystem (unlike gradle).

After #1988 there would be a ton of stuff in ./bin. Yet (I think) these utility scropts doesn't really belong in this repo.

What do you mean by a "ton of stuff"?

@lhstrh
Copy link
Member

lhstrh commented Sep 11, 2023

I also find the scripts useful and would like to keep them. If we want to make it abundantly clear that this is just meant as dev tooliing, we could rename bin to .bin...

@edwardalee
Copy link
Collaborator

For the record, I really prefer to avoid hidden directories.

@cmnrd
Copy link
Collaborator

cmnrd commented Sep 12, 2023

For the record, I really prefer to avoid hidden directories.

Me too. If we rename it, it should probably be to dev. But at the moment I don't see a compelling reason for doing so.

@lhstrh
Copy link
Member

lhstrh commented Sep 12, 2023

OK, then let's resolve this as a wontfix.

@lhstrh lhstrh closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@cmnrd cmnrd added the wontfix This will not be worked on label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants