-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing utils and Zephyr run scripts moved from util
folder
#1948
Conversation
This is ready for merge. The reason why some of the CI is still pending is that these tasks are moved to reactor-c. But the CI uses the ci.yml from master always so it will not take effect until it is merged. @ChadliaJerad FYI we are moving the trace utils to reactor-c, Marten made me aware of that you are working on some of the tracing tools in another branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this @erlingrj!
I removed the tracing CI checks from the list of required checks.
Merging this into master without merging reactor-c 259 means that the tracing utilities are no longer available at all. Can we reverse this merge until we are ready to merge both? |
Alternatively, can anyone see what is the problem of the CI for reactor-c? It cant find some tags in the lingua-franca repository |
Sure. I will handle this. |
util
folder
Addresses #1946 and #1947. Mainly removing all the tracing related utilities from
lingua-franca/util
and instead putting them inreactor-c
. We also install them to/usr/local/bin
by default (together with the RTI) but allow overriding of this.Related PRs:
Docs: lf-lang/lf-lang.github.io#151
reactor-c: lf-lang/reactor-c#259