Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing utils and Zephyr run scripts moved from util folder #1948

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

erlingrj
Copy link
Collaborator

Addresses #1946 and #1947. Mainly removing all the tracing related utilities from lingua-franca/util and instead putting them in reactor-c. We also install them to /usr/local/bin by default (together with the RTI) but allow overriding of this.

Related PRs:
Docs: lf-lang/lf-lang.github.io#151
reactor-c: lf-lang/reactor-c#259

@erlingrj erlingrj requested review from lhstrh and edwardalee August 18, 2023 06:03
@erlingrj
Copy link
Collaborator Author

This is ready for merge. The reason why some of the CI is still pending is that these tasks are moved to reactor-c. But the CI uses the ci.yml from master always so it will not take effect until it is merged.

@ChadliaJerad FYI we are moving the trace utils to reactor-c, Marten made me aware of that you are working on some of the tracing tools in another branch.

Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @erlingrj!

I removed the tracing CI checks from the list of required checks.

@cmnrd cmnrd linked an issue Aug 18, 2023 that may be closed by this pull request
@cmnrd cmnrd added this pull request to the merge queue Aug 18, 2023
Merged via the queue into master with commit b1611c5 Aug 18, 2023
@cmnrd cmnrd deleted the move-tracing-utils branch August 18, 2023 11:50
@edwardalee
Copy link
Collaborator

Merging this into master without merging reactor-c 259 means that the tracing utilities are no longer available at all. Can we reverse this merge until we are ready to merge both?

@erlingrj
Copy link
Collaborator Author

Alternatively, can anyone see what is the problem of the CI for reactor-c? It cant find some tags in the lingua-franca repository

@ChadliaJerad
Copy link
Collaborator

This is ready for merge. The reason why some of the CI is still pending is that these tasks are moved to reactor-c. But the CI uses the ci.yml from master always so it will not take effect until it is merged.

@ChadliaJerad FYI we are moving the trace utils to reactor-c, Marten made me aware of that you are working on some of the tracing tools in another branch.

Sure. I will handle this.

@petervdonovan petervdonovan changed the title Move tracing utils and zephyr run scripts from util folder Tracing utils and Zephyr run scripts moved from util folder Aug 26, 2023
@petervdonovan petervdonovan added the refactoring Code quality enhancement label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move util/tracing to separate repository or to reactor-c
5 participants