Removal of ulog from reactor-ts, code generator updated to allow this change
#2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to accommodate lf-lang/reactor-ts#237
lhstrh
changed the title
ulog removed from reactor-ts, code generator updated to allow this change
lhstrh
added
typescript
lhstrh
changed the title
ulog removed from reactor-ts, code generator updated to allow this changeulog from reactor-ts, code generator updated to allow this change
|
This is failing because of lf-lang/reactor-ts#239 Tests are passing on the reactor-ts side, so we should merge that first, then this. |
|
Hmm...... Zephyr test is failing? |
lhstrh
requested changes
Oct 14, 2023
core/src/main/kotlin/org/lflang/generator/ts/TSParameterPreambleGenerator.kt
Show resolved
Hide resolved
axmmisaka
force-pushed
the
reactor-ts-remove-ulog
branch
from
06e91c5
to
8a3472c
Compare
lhstrh
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log.global(renamed toLog.globalLogger); replaced withLog.error()andLog.setLevel();ulog.This is to accommodate lf-lang/reactor-ts#237