String literal allowed as property name #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Dec 18, 2023
lhstrh
changed the title
3 tasks
|
@oowekyala: I still think that it might be nice to be able to use keywords without quotes in the target properties, don't you? Being able to use quotes equally makes sense, but I'm think that we might want to merge both this PR and #1238, actually. |
lhstrh
force-pushed
the
keywords-in-target-properties
branch
from
2faa24a
to
5d8c01f
Compare
lhstrh
requested changes
Jan 6, 2024
lhstrh
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements this solution to #1194. It would supersede #1238.
This needs an update to the documentation website.