Parallel compilation disabled to avoid triggering deadlock in concurrent invocations of CMake #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
approved these changes
Jan 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Glad we finally found the source of the problem! Disabling for now is the right thing to do, and we can revisit and optimize later. |
lhstrh
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI, macOS tests have been nondeterministically failing because the federated tests lock up and get cancelled after a long time (originally 6 hours, recently modified to 2 hours). It turns out that these failures were due to the compiler locking up, not the generated federated programs. This PR disables parallel compilation of the federated programs, which apparently can cause such lock ups.