Include clock sync for federated programs on multiple platforms. #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM. CI will pass after running ./gradlew spotlessJavaApply.
I do not understand why this would fail to compile only when deployed on multiple machines, but the changes are clearly harmless and I do not think it is necessary to investigate this too deeply right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compile problem with federated Python reported by @vinzbarbuto where a federated Python program that maps to multiple machines fails to compile because of a missing
#includeofclock-sync.h. I don't know how to add a test because this compilation error does not occur when targeting a single machine. This PR also fixes a clearly erroneous comment and aligns reactor-c to main.