Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define self variable so it can be used in instantiations #2353

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

edwardalee
Copy link
Collaborator

In the Python target, when setting parameters of an instance, it is not possible in native initializer code to reference the parameters of the container. This PR fixes that and adds a test.

@edwardalee edwardalee added enhancement Enhancement of existing feature python Related to the Python target labels Jul 7, 2024
@edwardalee edwardalee requested a review from lhstrh July 7, 2024 11:28
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo nitpick.

test/Python/src/BankIndex.lf Outdated Show resolved Hide resolved
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edwardalee edwardalee added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit 4865086 Jul 11, 2024
26 checks passed
@edwardalee edwardalee deleted the self-defined branch July 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature python Related to the Python target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants