Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTI Docker Hub Continuous Deployment with Multiplatform Support #2384

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

Depetrol
Copy link
Collaborator

@Depetrol Depetrol commented Aug 1, 2024

This PR partially resolves lf-lang/reactor-c#470 by continuously deploying RTI images on Docker Hub with nightly and master tag.

  • RTI image with nightly tag is deployed to Docker Hub along publishing the nightly release.
  • RTI image with master tag is deployed to Docker Hub when a new commit is pushed to the master branch. This happens when a PR is merged.

To facilitate the continuous deployment process, two GitHub secrets need to be added:

  • DOCKERHUB_USERNAME: Docker Hub username, in this case it should be an account with push access to lflang/rti
  • DOCKERHUB_TOKEN: Corresponding Docker Hub Access Token.

The RTI image is built for the following platforms:

  • linux/amd64
  • linux/arm64
  • linux/arm/v7
  • linux/riscv64

@Depetrol Depetrol requested a review from lhstrh August 1, 2024 22:53
@Depetrol Depetrol added enhancement Enhancement of existing feature docker Issue related to the docker support labels Aug 1, 2024
@Depetrol Depetrol closed this Aug 1, 2024
@Depetrol Depetrol changed the title RTI Docker Hub Continuous Deployment RTI Docker Hub Continuous Deployment with Multiplatform Support Aug 1, 2024
@Depetrol
Copy link
Collaborator Author

Depetrol commented Aug 1, 2024

Reopening with build for multiple platforms.

@Depetrol Depetrol reopened this Aug 1, 2024
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some minor suggestions...

.github/workflows/rti-docker.yml Outdated Show resolved Hide resolved
.github/workflows/rti-docker.yml Outdated Show resolved Hide resolved
.github/workflows/rti-docker.yml Outdated Show resolved Hide resolved
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one change that needs to be added in order to make this work; the code generator should use the version number as well (instead of latest).

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but it appears our merge queue/CI is broken due to a failure in the Zehpyr tests...

feat: RTI dockerhub nightly CD

feat: RTI dockerhub master CD
feat: multiplatform build
Update .github/workflows/rti-docker.yml

Co-authored-by: Marten Lohstroh <[email protected]>

Update .github/workflows/rti-docker.yml

Co-authored-by: Marten Lohstroh <[email protected]>

Update .github/workflows/rti-docker.yml

Co-authored-by: Marten Lohstroh <[email protected]>

format

format
@lhstrh lhstrh enabled auto-merge August 2, 2024 19:22
@lhstrh lhstrh added this pull request to the merge queue Aug 2, 2024
Merged via the queue into lf-lang:master with commit 3828049 Aug 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issue related to the docker support enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for RTI docker image Continuous Deployment
2 participants