-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTI Docker Hub Continuous Deployment with Multiplatform Support #2384
Conversation
Reopening with build for multiple platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some minor suggestions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one change that needs to be added in order to make this work; the code generator should use the version number as well (instead of latest
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but it appears our merge queue/CI is broken due to a failure in the Zehpyr tests...
feat: RTI dockerhub nightly CD feat: RTI dockerhub master CD
feat: multiplatform build
format update
Update .github/workflows/rti-docker.yml Co-authored-by: Marten Lohstroh <[email protected]> Update .github/workflows/rti-docker.yml Co-authored-by: Marten Lohstroh <[email protected]> Update .github/workflows/rti-docker.yml Co-authored-by: Marten Lohstroh <[email protected]> format format
This PR partially resolves lf-lang/reactor-c#470 by continuously deploying RTI images on Docker Hub with
nightly
andmaster
tag.nightly
tag is deployed to Docker Hub along publishing the nightly release.master
tag is deployed to Docker Hub when a new commit is pushed to themaster
branch. This happens when a PR is merged.To facilitate the continuous deployment process, two GitHub secrets need to be added:
lflang/rti
The RTI image is built for the following platforms: