Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bank_index Parameter Override #2411

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Fix bank_index Parameter Override #2411

merged 6 commits into from
Sep 27, 2024

Conversation

Depetrol
Copy link
Collaborator

This PR solves #2410 by allowing explicitly set bank_index parameter to override in Python target.

@Depetrol Depetrol added bug Something isn't working python Related to the Python target federated labels Sep 26, 2024
@Depetrol Depetrol added bugfix and removed bug Something isn't working labels Sep 26, 2024
@Depetrol Depetrol linked an issue Sep 26, 2024 that may be closed by this pull request
Bank of federates always have bank_index of 0 in python target #2410
Closed
edwardalee
edwardalee approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM, except that you seem to have an unintended and unrelated change.

test/Cpp/src/ActionWithNoReaction.lf Outdated Show resolved Hide resolved
@lhstrh lhstrh added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 7141aca Sep 27, 2024
24 checks passed
@lhstrh lhstrh deleted the bank-of-feds-py branch September 27, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix federated python Related to the Python target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bank of federates always have bank_index of 0 in python target
3 participants
@Depetrol @edwardalee @lhstrh