Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameterized mutable inputs #2420

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Fixed parameterized mutable inputs #2420

merged 6 commits into from
Oct 3, 2024

Conversation

edwardalee
Copy link
Collaborator

Fixed #2117 and added tests. There is companion PR in reactor-c.

Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlingrj
Copy link
Collaborator

erlingrj commented Oct 3, 2024

I am a little surprised that we have a test for Enclaved shutdown as we don't "officially" support enclaves in the C target and a coordinated shutdown of the enclaves is a subtle topic. I will take a quick look. It probably has to do with the change you made regarding scheduling the very first timer event if it is passed the timeout time

@edwardalee edwardalee added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@edwardalee edwardalee added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit ae1740e Oct 3, 2024
24 checks passed
@edwardalee edwardalee deleted the mutable branch October 3, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized mutable multiport inputs does not work
2 participants