-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed argparse for fedsd
#273
Conversation
In the last update,
and
Actually, I didn't see any value in explicitly saying
Apologies for the overlook. Thanks for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ChadliaJerad, these are the docs I am referring to: https://www.lf-lang.org/docs/handbook/tracing?target=c#tracing-federated-programs |
I see! This is the handbook PR. Commit 728e725 fixes some typos, while Commit 9ea185a adjuts the README file contents with this commit. |
The docs are not up-to-date, fedsd doesnt work with
fedsd *.lft
, you have to dofedsd -r rti.lft -f fed1.lft fed2.lft
.This fixes the argparse setup so that the command line parsing works properly. Previously it turned the list of federate lfts into a double list [[lft1, fft2, ...,]] which crashed the rest of the script