Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print more info when assertion fails #376

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Print more info when assertion fails #376

merged 3 commits into from
Mar 1, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Mar 1, 2024 •
edited
Loading

Also print FILE, LINE and func so we now exactly where an assertion fails.

@erlingrj erlingrj requested a review from edwardalee March 1, 2024 07:57
@erlingrj erlingrj mentioned this pull request Mar 1, 2024
Open
edwardalee
edwardalee approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlingrj erlingrj merged commit 639bbdd into main Mar 1, 2024
20 checks passed
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Apr 27, 2024
@erlingrj erlingrj deleted the better-assertions branch May 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlingrj @edwardalee @lhstrh