Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP2040 support based on low-level platform API #441

Merged
merged 2 commits into from
Jun 3, 2024
Merged

RP2040 support based on low-level platform API #441

merged 2 commits into from
Jun 3, 2024

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented May 31, 2024

This PR removes the use of macros defined in util.h because #including util.h does not work.
To build RP2040 code, we also need the companion PR.

@lhstrh
Copy link
Member

lhstrh commented May 31, 2024

While the change looks good to me, it doesn't seem to match the description of the PR. This seems to just deal with an API change.

@lhstrh lhstrh changed the title Do not use macros in util.h, which seems impossible to #include RP2040 support based on low-level platform API May 31, 2024
@lhstrh lhstrh requested a review from petervdonovan May 31, 2024 18:10
@edwardalee edwardalee mentioned this pull request Jun 2, 2024
@lhstrh lhstrh enabled auto-merge June 3, 2024 05:25
@lhstrh lhstrh added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 587a8f9 Jun 3, 2024
29 checks passed
@cmnrd cmnrd deleted the rp2040-fixes branch June 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants