Fixed initialization of the master worker thread id #454
Conversation
WalkthroughThe changes introduced thread ID handling modifications to ensure Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- core/threaded/reactor_threaded.c (1 hunks)
Additional comments not posted (1)
core/threaded/reactor_threaded.c (1)
1115-1115: Initialization of the master worker thread ID is correctly implemented.The modification ensures that
env->thread_ids[j]is assigned the ID of the main thread whenjis zero. This directly addresses the issue where the main thread's ID was previously uninitialized, potentially leading to segmentation faults when accessed. By usinglf_thread_self(), the code correctly captures the current thread's ID and assigns it, ensuring that all thread-related operations that rely on this ID are handled correctly.
|
Unfortunately, this does not work as there is no implementation of |
Also, silence undefined reference linker errors on other platforms that either have no support or that do not currently implement the API
Fix compilation errors in `initialize-master-thread-id`
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- low_level_platform/impl/src/lf_arduino_support.c (1 hunks)
- low_level_platform/impl/src/lf_flexpret_support.c (1 hunks)
- low_level_platform/impl/src/lf_windows_support.c (1 hunks)
Files not reviewed due to errors (1)
- low_level_platform/impl/src/lf_flexpret_support.c (no review received)
Additional comments not posted (1)
low_level_platform/impl/src/lf_windows_support.c (1)
165-166: Proper Implementation oflf_thread_self()The implementation of
lf_thread_self()usingGetCurrentThread()is appropriate for Windows platforms. This ensures that the function behaves as expected, avoiding the issues noted in other platform-specific implementations.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- low_level_platform/impl/src/lf_arduino_support.c (1 hunks)
- low_level_platform/impl/src/lf_flexpret_support.c (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- low_level_platform/impl/src/lf_arduino_support.c
- low_level_platform/impl/src/lf_flexpret_support.c
This pulls in lf-lang/reactor-c#454
This pulls in lf-lang/reactor-c#454
Fixes #452
Summary by CodeRabbit
lf_thread_self()function for improved thread handling across multiple platforms, including Arduino, FlexPRET, and Windows.