Portable backtrace mechanism #59
Merged
+41
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
force-pushed
the
cmake-execinfo
branch
4 times, most recently
from
027f8a0
to
63ff906
Compare
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Jul 17, 2024
Alpine has dropped support for libexecinfo since version 3.17. This PR pulls in lf-lang/reactor-cpp#59 which makes the compilation of reactor-cpp more robust, so that it can handle if backtrace support is not available or provided by an alternative implementation. Consequently, we can remove the current workarounds in the LF code generator.
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Jul 17, 2024
Alpine has dropped support for libexecinfo since version 3.17. This PR pulls in lf-lang/reactor-cpp#59 which makes the compilation of reactor-cpp more robust, so that it can handle if backtrace support is not available or provided by an alternative implementation. Consequently, we can remove the current workarounds in the LF code generator.
tanneberger
reviewed
Jul 17, 2024
tanneberger
reviewed
Jul 17, 2024
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Jul 23, 2024
Alpine has dropped support for libexecinfo since version 3.17. This PR pulls in lf-lang/reactor-cpp#59 which makes the compilation of reactor-cpp more robust, so that it can handle if backtrace support is not available or provided by an alternative implementation. Consequently, we can remove the current workarounds in the LF code generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the backtrace mechanism that we currently use for assertions portable. The current mechanism was implemented under the assumption, that all Linux distributions provide
execinfo.h, which is not the case (e.g. Alpine has dropped libexecinfo). This PR provides a more robust implementation that uses FindBacktrace to find the correct backtrace implementation.This change allows us to simplify the docker support in LF.