Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra image requests #20

Open
GMart opened this issue Apr 23, 2024 · 3 comments
Open

Remove extra image requests #20

GMart opened this issue Apr 23, 2024 · 3 comments

Comments

@GMart
Copy link
Contributor

GMart commented Apr 23, 2024

The site currently requests about 2 dozen device images that don't exist each time the site loads. There could be a check to make sure the image exists before trying to load the image.
Or we can add a placeholder image for each device type.
I guess there already is one, but not sure how that is generated.

@liamcottle
Copy link
Owner

Related: #18 (comment)

@liamcottle
Copy link
Owner

This adds an extra 1mb or so to responses, since there's like 12k nodes in the db now lol...

https://github.com/liamcottle/meshtastic-map/tree/feature/hardware-model-image-urls

@GMart
Copy link
Contributor Author

GMart commented Apr 25, 2024

Ok, then I guess the current way works fine.
Could you add a server side script, then the response would only be the current device types with image urls? So maybe 30 URLs total. It would only need to update maybe once per day.
I'm not up to date with how scripting works these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants