From 5b48d25d22efa218baccc841d865b87e5d527743 Mon Sep 17 00:00:00 2001
From: liamcottle <liam@liamcottle.com>
Date: Sun, 17 Nov 2024 23:07:57 +1300
Subject: [PATCH] refactor nodes ui to node list item

---
 src/components/nodes/NodeListItem.vue | 82 +++++++++++++++++++++++++++
 src/components/nodes/NodesList.vue    | 68 ++--------------------
 2 files changed, 87 insertions(+), 63 deletions(-)
 create mode 100644 src/components/nodes/NodeListItem.vue

diff --git a/src/components/nodes/NodeListItem.vue b/src/components/nodes/NodeListItem.vue
new file mode 100644
index 0000000..8f0b506
--- /dev/null
+++ b/src/components/nodes/NodeListItem.vue
@@ -0,0 +1,82 @@
+<template>
+    <div class="flex cursor-pointer p-2 bg-white hover:bg-gray-50">
+
+        <!-- icon -->
+        <NodeIcon :node="node" class="my-auto mr-2"/>
+
+        <!-- name and info -->
+        <div class="mr-auto">
+            <div>{{ getNodeLongName(node.num) }}</div>
+            <div class="text-sm text-gray-500">
+
+                <!-- our node info -->
+                <div v-if="node.num === GlobalState.myNodeId">
+                    You are connected to this node
+                </div>
+
+                <!-- other node info -->
+                <div v-else class="flex space-x-1">
+
+                    <span class="my-auto">
+                        <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="currentColor" class="size-4">
+                            <path d="M9 8a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z" />
+                            <path fill-rule="evenodd" d="M9.68 5.26a.75.75 0 0 1 1.06 0 3.875 3.875 0 0 1 0 5.48.75.75 0 1 1-1.06-1.06 2.375 2.375 0 0 0 0-3.36.75.75 0 0 1 0-1.06Zm-3.36 0a.75.75 0 0 1 0 1.06 2.375 2.375 0 0 0 0 3.36.75.75 0 1 1-1.06 1.06 3.875 3.875 0 0 1 0-5.48.75.75 0 0 1 1.06 0Z" clip-rule="evenodd" />
+                            <path fill-rule="evenodd" d="M11.89 3.05a.75.75 0 0 1 1.06 0 7 7 0 0 1 0 9.9.75.75 0 1 1-1.06-1.06 5.5 5.5 0 0 0 0-7.78.75.75 0 0 1 0-1.06Zm-7.78 0a.75.75 0 0 1 0 1.06 5.5 5.5 0 0 0 0 7.78.75.75 0 1 1-1.06 1.06 7 7 0 0 1 0-9.9.75.75 0 0 1 1.06 0Z" clip-rule="evenodd" />
+                        </svg>
+                    </span>
+
+                    <!-- last heard -->
+                    <span class="flex my-auto text-sm text-gray-500 space-x-1">
+                        {{ formatUnixSecondsAgo(node.lastHeard) }}
+                    </span>
+
+                    <!-- hops away -->
+                    <span class="flex my-auto text-sm text-gray-500 space-x-1">
+                        <span>•</span>
+                        <span v-if="node.hopsAway === -1">???</span>
+                        <span v-else-if="node.hopsAway === 0">Direct</span>
+                        <span v-else-if="node.hopsAway === 1">1 Hop</span>
+                        <span v-else>{{ node.hopsAway }} Hops</span>
+                    </span>
+
+                </div>
+
+            </div>
+        </div>
+
+        <!-- node dropdown menu -->
+        <NodeDropDownMenu :node="node"/>
+
+    </div>
+</template>
+
+<script>
+import NodeIcon from "./NodeIcon.vue";
+import NodeUtils from "../../js/NodeUtils.js";
+import NodeDropDownMenu from "./NodeDropDownMenu.vue";
+import GlobalState from "../../js/GlobalState.js";
+import TimeUtils from "../../js/TimeUtils.js";
+import moment from "moment";
+
+export default {
+    name: 'NodeListItem',
+    components: {
+        NodeDropDownMenu,
+        NodeIcon,
+    },
+    props: {
+        node: Object,
+    },
+    methods: {
+        getNodeLongName: (nodeId) => NodeUtils.getNodeLongName(nodeId),
+        formatUnixSecondsAgo(unixSeconds) {
+            return TimeUtils.getTimeAgoShortHand(moment.unix(unixSeconds).toDate());
+        },
+    },
+    computed: {
+        GlobalState() {
+            return GlobalState;
+        },
+    },
+}
+</script>
diff --git a/src/components/nodes/NodesList.vue b/src/components/nodes/NodesList.vue
index 3c3dd26..d3321a2 100644
--- a/src/components/nodes/NodesList.vue
+++ b/src/components/nodes/NodesList.vue
@@ -8,55 +8,7 @@
 
         <!-- nodes -->
         <div class="h-full overflow-y-auto">
-            <div :key="node.num" v-for="node of searchedNodes" @click="onNodeClick(node)" class="flex cursor-pointer p-2 border-l-2" :class="[ selectedNodeId === node.num ? 'bg-gray-100 border-blue-500' : 'bg-white border-transparent hover:bg-gray-50 hover:border-gray-200']">
-
-                <!-- icon -->
-                <NodeIcon :node="node" class="my-auto mr-2"/>
-
-                <!-- name and info -->
-                <div class="mr-auto">
-                    <div>{{ getNodeLongName(node.num) }}</div>
-                    <div class="text-sm text-gray-500">
-
-                        <!-- our node info -->
-                        <div v-if="node.num === GlobalState.myNodeId">
-                            You are connected to this node
-                        </div>
-
-                        <!-- other node info -->
-                        <div v-else class="flex space-x-1">
-
-                            <span class="my-auto">
-                                <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="currentColor" class="size-4">
-                                    <path d="M9 8a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z" />
-                                    <path fill-rule="evenodd" d="M9.68 5.26a.75.75 0 0 1 1.06 0 3.875 3.875 0 0 1 0 5.48.75.75 0 1 1-1.06-1.06 2.375 2.375 0 0 0 0-3.36.75.75 0 0 1 0-1.06Zm-3.36 0a.75.75 0 0 1 0 1.06 2.375 2.375 0 0 0 0 3.36.75.75 0 1 1-1.06 1.06 3.875 3.875 0 0 1 0-5.48.75.75 0 0 1 1.06 0Z" clip-rule="evenodd" />
-                                    <path fill-rule="evenodd" d="M11.89 3.05a.75.75 0 0 1 1.06 0 7 7 0 0 1 0 9.9.75.75 0 1 1-1.06-1.06 5.5 5.5 0 0 0 0-7.78.75.75 0 0 1 0-1.06Zm-7.78 0a.75.75 0 0 1 0 1.06 5.5 5.5 0 0 0 0 7.78.75.75 0 1 1-1.06 1.06 7 7 0 0 1 0-9.9.75.75 0 0 1 1.06 0Z" clip-rule="evenodd" />
-                                </svg>
-                            </span>
-
-                            <!-- last heard -->
-                            <span class="flex my-auto text-sm text-gray-500 space-x-1">
-                                {{ formatUnixSecondsAgo(node.lastHeard) }}
-                            </span>
-
-                            <!-- hops away -->
-                            <span class="flex my-auto text-sm text-gray-500 space-x-1">
-                                <span>•</span>
-                                <span v-if="node.hopsAway === -1">???</span>
-                                <span v-else-if="node.hopsAway === 0">Direct</span>
-                                <span v-else-if="node.hopsAway === 1">1 Hop</span>
-                                <span v-else>{{ node.hopsAway }} Hops</span>
-                            </span>
-
-                        </div>
-
-                    </div>
-                </div>
-
-                <!-- node dropdown menu -->
-                <NodeDropDownMenu :node="node"/>
-
-            </div>
+            <NodeListItem :key="node.num" v-for="node of searchedNodes" :node="node" @click="onNodeClick(node)"/>
         </div>
 
     </div>
@@ -64,23 +16,18 @@
 
 <script>
 import NodeUtils from "../../js/NodeUtils.js";
-import moment from "moment";
-import NodeIcon from "./NodeIcon.vue";
 import GlobalState from "../../js/GlobalState.js";
-import NodeDropDownMenu from "./NodeDropDownMenu.vue";
-import TimeUtils from "../../js/TimeUtils.js";
+import NodeListItem from "./NodeListItem.vue";
 
 export default {
     name: 'NodesList',
     components: {
-        NodeDropDownMenu,
-        NodeIcon,
+        NodeListItem,
     },
     emits: [
         "node-click",
     ],
     props: {
-        selectedNodeId: Number,
         nodes: Array,
     },
     data() {
@@ -89,16 +36,11 @@ export default {
         };
     },
     methods: {
-        onNodeClick(node) {
-            this.$emit("node-click", node);
-        },
         getNodeHexId: (nodeId) => NodeUtils.getNodeHexId(nodeId),
         getNodeShortName: (nodeId) => NodeUtils.getNodeShortName(nodeId),
         getNodeLongName: (nodeId) => NodeUtils.getNodeLongName(nodeId),
-        getNodeColour: (nodeId) => NodeUtils.getNodeColour(nodeId),
-        getNodeTextColour: (nodeId) => NodeUtils.getNodeTextColour(nodeId),
-        formatUnixSecondsAgo(unixSeconds) {
-            return TimeUtils.getTimeAgoShortHand(moment.unix(unixSeconds).toDate());
+        onNodeClick(node) {
+            this.$emit("node-click", node);
         },
     },
     computed: {