From e14075bb19e3cf0984e0baa376e39eb352ae3a7f Mon Sep 17 00:00:00 2001
From: liamcottle <liam@liamcottle.com>
Date: Sun, 8 Dec 2024 14:32:06 +1300
Subject: [PATCH] add button to refresh node position

---
 src/components/pages/NodePage.vue | 36 +++++++++++++++++++++++++++++--
 src/js/Connection.js              | 18 ++++++++++++++++
 src/js/NodeAPI.js                 | 22 +++++++++++++++++++
 3 files changed, 74 insertions(+), 2 deletions(-)

diff --git a/src/components/pages/NodePage.vue b/src/components/pages/NodePage.vue
index a9d162f..e148fcf 100644
--- a/src/components/pages/NodePage.vue
+++ b/src/components/pages/NodePage.vue
@@ -71,7 +71,12 @@
 
                 <!-- position -->
                 <div>
-                    <div class="flex bg-gray-200 p-2 font-semibold">Position</div>
+                    <div class="flex bg-gray-200 p-2 font-semibold items-center">
+                        <div>Position</div>
+                        <div class="ml-auto">
+                            <RefreshButton @click="requestPosition" :is-refreshing="isRequestingPosition"/>
+                        </div>
+                    </div>
                     <ul role="list" class="flex-1 divide-y divide-gray-200">
 
                         <!-- position -->
@@ -87,7 +92,7 @@
                         <li class="flex p-3">
                             <div class="text-sm font-medium text-gray-900">Altitude</div>
                             <div class="ml-auto text-sm text-gray-700">
-                                <span v-if="node.position && node.position.altitude != null">{{ node.position.altitude }}</span>
+                                <span v-if="node.position && node.position.altitude">{{ node.position.altitude }}</span>
                                 <span v-else>???</span>
                             </div>
 
@@ -189,6 +194,7 @@ export default {
     data() {
         return {
             isRequestingDeviceMetrics: false,
+            isRequestingPosition: false,
         };
     },
     mounted() {
@@ -252,6 +258,32 @@ export default {
             this.isRequestingDeviceMetrics = false;
 
         },
+        async requestPosition() {
+
+            // do nothing if already requesting position
+            if(this.isRequestingPosition){
+                return;
+            }
+
+            // show loading
+            this.isRequestingPosition = true;
+
+            try {
+
+                // fetch position from node
+                const position = await NodeAPI.requestPosition(this.node.num);
+
+                // update this nodes position
+                this.node.position = position;
+
+            } catch(e) {
+                DialogUtils.showErrorAlert(e);
+            }
+
+            // no longer requesting position
+            this.isRequestingPosition = false;
+
+        },
     },
     computed: {
         node() {
diff --git a/src/js/Connection.js b/src/js/Connection.js
index 65236b9..323df91 100644
--- a/src/js/Connection.js
+++ b/src/js/Connection.js
@@ -404,6 +404,24 @@ class Connection {
 
         });
 
+        // listen for positions
+        connection.events.onPositionPacket.subscribe(async (positionPacket) => {
+
+            await databaseToBeReady;
+            console.log("onPositionPacket", positionPacket);
+
+            // find node this position is from, otherwise do nothing
+            const from = positionPacket.from;
+            const node = GlobalState.nodesById[from];
+            if(!node){
+                return;
+            }
+
+            // update position for node
+            node.position = positionPacket.data;
+
+        });
+
     }
 
     static async onPacketAck(requestId, ackedByNodeId, hopsAway) {
diff --git a/src/js/NodeAPI.js b/src/js/NodeAPI.js
index 84ec167..5473da7 100644
--- a/src/js/NodeAPI.js
+++ b/src/js/NodeAPI.js
@@ -400,6 +400,28 @@ class NodeAPI {
 
     }
 
+    /**
+     * Sends our Position to, and requests the Position from the provided nodeId
+     * @param nodeId the node id to exchange Position with
+     * @returns {Promise<*>}
+     */
+    static async requestPosition(nodeId) {
+
+        // create empty position message
+        // todo send our actual position
+        const position = Protobuf.Mesh.Position.fromJson({});
+
+        // send packet and wait for response
+        const portNum = Protobuf.Portnums.PortNum.POSITION_APP;
+        const byteData = position.toBinary();
+        const channel = NodeUtils.getNodeChannel(nodeId);
+        const responseMeshPacket = await this.sendPacketAndWaitForResponse(nodeId, portNum, byteData, channel, true);
+
+        // return position from response
+        return Protobuf.Mesh.Position.fromBinary(responseMeshPacket.payloadVariant.value.payload);
+
+    }
+
     /**
      * Sends an AdminMessage to the provided node id, and waits for a response, or timeouts out after the provided delay
      * @param nodeId the node id to send the admin message to