You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given the nature of this issue in comparison to #206, we can track the scope of this issue in 206 as the diagrams here would, in part, also be used for other docs in the NAT section, and we are tracking all the other diagram updates in 206.
Going forward, we should follow the libp2p blog post approach and include new diagrams and graphics as part of the change request. However, given that the open PRs (many documenting protocols and process) have been hanging for some time, my approach was to get those merged and add the diagrams shortly after to limit the friction.
In the near term where there is little to no "doc debt", we'll make it a habit to request diagrams as documents are created and ship them together.
We currently use UML sequence diagrams in the Hole Punching documentation:
We need to replace these with updated diagrams when they become available.
See the discussion here: https://github.com/libp2p/docs/pull/200/files#r980363822
The text was updated successfully, but these errors were encountered: