Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely go routine leak of handleSendingMessages #38

Closed
Stebalien opened this issue Sep 29, 2017 · 1 comment · Fixed by #39
Closed

Likely go routine leak of handleSendingMessages #38

Stebalien opened this issue Sep 29, 2017 · 1 comment · Fixed by #39
Assignees
@Stebalien
Labels
P0 Critical: Tackled by core team ASAP

Comments

@Stebalien
Copy link
Member

Probably an issue with stream closing versus resetting.
@Stebalien Stebalien self-assigned this Sep 29, 2017
@whyrusleeping
Copy link
Contributor

The leak is coming from the fact that if we never send a message to a peer, then this goroutine will never close: https://github.com/libp2p/go-floodsub/blob/master/comm.go#L56

Stebalien added a commit that referenced this issue Oct 14, 2017
@Stebalien
mark the peer as dead if the inbound stream closes
3e0c53e 
fixes #38
@Stebalien Stebalien mentioned this issue Oct 14, 2017
Merged
@whyrusleeping whyrusleeping added the P0 Critical: Tackled by core team ASAP label Oct 17, 2017
@whyrusleeping whyrusleeping mentioned this issue Oct 17, 2017
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark the peer as dead if the inbound stream closes libp2p/go-libp2p-pubsub
2 participants
@Stebalien @whyrusleeping