fix: multicodec topology update peers with multicodec (#10)

libp2p · Nov 15, 2019 · 21d8ae6 · 21d8ae6
1 parent 5969270
commit 21d8ae6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/topology/multicodec-topology.js b/src/topology/multicodec-topology.js
@@ -50,7 +50,7 @@ class MulticodecTopology extends Topology {
    */
   _updatePeers (peerInfoIterable) {
     for (const peerInfo of peerInfoIterable) {
-      if (this.multicodecs.filter(multicodec => peerInfo.protocols.has(multicodec))) {
+      if (this.multicodecs.filter(multicodec => peerInfo.protocols.has(multicodec)).length) {
         // Add the peer regardless of whether or not there is currently a connection
         this.peers.set(peerInfo.id.toB58String(), peerInfo)
         // If there is a connection, call _onConnect

diff --git a/src/topology/tests/multicodec-topology.js b/src/topology/tests/multicodec-topology.js
@@ -49,6 +49,7 @@ module.exports = (test) => {
 
       const id2 = await PeerId.createFromJSON(peers[1])
       const peer2 = await PeerInfo.create(id2)
+      topology.multicodecs.forEach((m) => peer2.protocols.add(m))
 
       const peerStore = topology._registrar.peerStore
       peerStore.emit('change:protocols', {
@@ -66,16 +67,17 @@ module.exports = (test) => {
 
       const id2 = await PeerId.createFromJSON(peers[1])
       const peer2 = await PeerInfo.create(id2)
-      const peerStore = topology._registrar.peerStore
+      topology.multicodecs.forEach((m) => peer2.protocols.add(m))
 
-      // Peer with the protocol
+      const peerStore = topology._registrar.peerStore
       peerStore.emit('change:protocols', {
         peerInfo: peer2,
         protocols: Array.from(topology.multicodecs)
       })
 
       expect(topology.peers.size).to.eql(1)
 
+      topology.multicodecs.forEach((m) => peer2.protocols.delete(m))
       // Peer does not support the protocol anymore
       peerStore.emit('change:protocols', {
         peerInfo: peer2,