This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
chore: monorepo separating interfaces and compliance tests #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/monorepo-separating-interfaces-and-compliance-tests
branch
16 times, most recently
from
f0700d7 to
a3e18cf
Compare
vasco-santos
force-pushed
the
chore/monorepo-separating-interfaces-and-compliance-tests
branch
from
a3e18cf to
abbea77
Compare
vasco-santos
commented
Jun 24, 2021
| "it-goodbye": "^3.0.0", | ||
| "it-pair": "^1.0.0", | ||
| "it-pipe": "^1.1.0", | ||
| "libp2p-interfaces": "^0.11.0", |
There was a problem hiding this comment.
@achingbrain how do you handle dependency updates of adjacent modules?
There was a problem hiding this comment.
Do you mean when sibling versions change within a monorepo? Lerna takes care of all that.
achingbrain
force-pushed
the
chore/monorepo-separating-interfaces-and-compliance-tests
branch
4 times, most recently
from
bf7b63e to
3cb0ed9
Compare
achingbrain
force-pushed
the
chore/monorepo-separating-interfaces-and-compliance-tests
branch
from
3cb0ed9 to
9f4e3c9
Compare
achingbrain
approved these changes
Jul 7, 2021
vasco-santos
deleted the
chore/monorepo-separating-interfaces-and-compliance-tests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes libp2p-interfaces a monorepo with its interfaces and compliance tests in two different modules.
Closes #58
BREAKING CHANGE: the tests now live in the
libp2p-interfaces-compliance-testsmodule