Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Speed up with some native code #118

Open
mkg20001 opened this issue Apr 2, 2018 · 3 comments
Open

Speed up with some native code #118

mkg20001 opened this issue Apr 2, 2018 · 3 comments
Labels
status/ready Ready to be worked

Comments

@mkg20001
Copy link
Member

mkg20001 commented Apr 2, 2018

Some functions use JS modules as there is no native function exposed by nodeJS.
Currently I'm developing https://github.com/mkg20001/c-libp2p-crypto which could be integrated in this module to replace some of the non-native code to further improve performance.

@dryajov
Copy link
Member

dryajov commented Apr 2, 2018

This needs to work in the browser as well, we should compile c-libp2p-crypto to wasm.

@mkg20001
Copy link
Member Author

mkg20001 commented Apr 2, 2018

Should work but if it doesn't we can always just fallback to what's currently used.

@dignifiedquire
Copy link
Member

This would need detailed analysis of speed and size impact, I have seen a lot of emscripten work be not faster or same speed + massive bundle size increase, both of which we want to avoid.

Also https://github.com/libp2p/rust-libp2p is coming along nicely and compiling to webassembly, might be easier to reuse what they have once that is fully working.

@daviddias daviddias added the status/ready Ready to be worked label Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

4 participants