bug: stop using ErrorResponse as field name #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or is the field name
|
Ran the tests locally, and the tests pass (except for the ones that are also failing in master) |
mvid
changed the title
vasco-santos
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
LGTM! Thanks @mvid
This is right, the property name should be error instead of ErrorResponse!
I tried this locally, and getPublicKey test for the dht is not working properly. I will skip it for now and open an issue fixing it in a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorResponseis the type,erroris the field name