Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

fix: simpler pubsub #172

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix: simpler pubsub #172

merged 1 commit into from
Feb 18, 2022

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Feb 18, 2022

Pubsub is an EventTarget instead of an EventEmitter, and extending classes don't need to worry about RPC details (unless they want to).

Updates the RPC definitions to be the same as go-libp2p.

Interface tests are also run using proper mocks that do multistream select, etc so they are more realistic.

@achingbrain achingbrain merged commit 98715ed into master Feb 18, 2022
@achingbrain achingbrain deleted the fix/simpler-pubsub branch February 18, 2022 06:56
github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

🎉 This PR is included in version @libp2p/interfaces-v1.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-id-v1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-map-v1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

🎉 This PR is included in version @libp2p/pubsub-v1.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

🎉 This PR is included in version @libp2p/interface-compliance-tests-v1.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant