This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: pubsub and dht are always set #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since libp2p/js-libp2p#1193 there will be values for pubsub and dht so no need to return them as maybe-undefined.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
## [@libp2p/interfaces-v1.3.25](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v1.3.24...@libp2p/interfaces-v1.3.25) (2022-04-28) ### Bug Fixes * pubsub and dht are always set ([#203](#203)) ([86860c1](86860c1))
|
🎉 This PR is included in version @libp2p/interfaces-v1.3.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
## [@libp2p/interface-compliance-tests-v1.1.28](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-compliance-tests-v1.1.27...@libp2p/interface-compliance-tests-v1.1.28) (2022-04-28) ### Bug Fixes * pubsub and dht are always set ([#203](#203)) ([86860c1](86860c1))
|
🎉 This PR is included in version @libp2p/interface-compliance-tests-v1.1.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libp2p/js-libp2p#1193 there will be values for pubsub and dht so no need to return them as maybe-undefined.
Also make mock-muxer logs a little less chatty.