Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Update peer and content routing return types in the readmes #48

Closed
jacobheun opened this issue Apr 23, 2020 · 1 comment
Closed

Update peer and content routing return types in the readmes #48

jacobheun opened this issue Apr 23, 2020 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) topic/docs Documentation

Comments

@jacobheun
Copy link
Contributor

With the upcoming removal of PeerInfo we should fix the content / peer routing return types to better match other interfaces. When returning { id: <PeerId>, addrs: <Multiaddr[]> }, we should instead return { id: <PeerId>, multiaddrs: <Multiaddr[]> }.

Ref: libp2p/js-libp2p-delegated-peer-routing#25 (comment)

cc @vasco-santos
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) topic/docs Documentation labels Apr 23, 2020
@vasco-santos vasco-santos mentioned this issue Apr 23, 2020
Merged
@vasco-santos
Copy link
Member

Closed in #49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos