From 3cd46fbfa2b9acda9a1337ab37e9ef15cdd8c251 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Thu, 10 Feb 2022 08:37:53 +0200 Subject: [PATCH] fix: remove args from listener events Cannot return a Connection on listen because we don't have one until a peer connects to the listener. --- .../src/transport/listen-test.ts | 2 +- packages/libp2p-interfaces/src/transport/index.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/libp2p-interface-compliance-tests/src/transport/listen-test.ts b/packages/libp2p-interface-compliance-tests/src/transport/listen-test.ts index d94dfdf53..bcbfaf2ac 100644 --- a/packages/libp2p-interface-compliance-tests/src/transport/listen-test.ts +++ b/packages/libp2p-interface-compliance-tests/src/transport/listen-test.ts @@ -147,7 +147,7 @@ export default (common: TestSetup) => { it('close', (done) => { const listener = transport.createListener() - listener.addEventListener('close', done) + listener.addEventListener('close', () => done()) void (async () => { await listener.listen(addrs[0]) diff --git a/packages/libp2p-interfaces/src/transport/index.ts b/packages/libp2p-interfaces/src/transport/index.ts index 111e22973..846b8482f 100644 --- a/packages/libp2p-interfaces/src/transport/index.ts +++ b/packages/libp2p-interfaces/src/transport/index.ts @@ -35,9 +35,9 @@ export interface Transport - 'listening': CustomEvent + 'listening': CustomEvent 'error': CustomEvent - 'close': CustomEvent + 'close': CustomEvent } export interface Listener extends EventEmitter {