Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: async peer store #272

Merged
merged 2 commits into from
Dec 30, 2021
Merged

feat: async peer store #272

merged 2 commits into from
Dec 30, 2021

Conversation

achingbrain
Copy link
Member

Refactors interfaces and classes used by libp2p-interfaces to use the async peer store from libp2p/js-libp2p#1058

BREAKING CHANGE: peerstore methods are now all async

Refactors interfaces and classes used by `libp2p-interfaces` to use the async peer store from libp2p/js-libp2p#1058

BREAKING CHANGE: peerstore methods are now all async
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! There is an issue with the types somewhere though

@achingbrain
Copy link
Member Author

achingbrain commented Dec 29, 2021

Yeah - there's a circular dependency between libp2p-kad-dht and libp2p which makes breaking APIs like this hard.

@achingbrain achingbrain merged commit 12804e2 into master Dec 30, 2021
@achingbrain achingbrain deleted the feat/async-peerstore branch December 30, 2021 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants