fix: remove p-map dependency

[abetaev]

this module depends on node API making @libp2p/kad-dht unusable in browser.

[wemeetagain]

LGTM

[github-actions]

🎉 This PR is included in version 1.0.12 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[achingbrain]

making @libp2p/kad-dht unusable in browser

This module is used in the browser by libp2p and ipfs, tested in CI, etc so this may not solve your problem. What's the error message you are seeing?

[abetaev]

@achingbrain

this may not solve your problem

actually, it did,

What's the error message you are seeing?

p-map -> aggregate-error -> clean-stack - there's import of os module.
particularly in firefox i saw this stacktrace before change:

Uncaught Error: Module "os" has been externalized for browser compatibility and cannot be accessed in client code.
    get os:3
    <anonymous> index.js:6
[os:3:10](browser-external:os)
    get os:3
    <anonymous> index.js:6
    InnerModuleEvaluation self-hosted:2331
    InnerModuleEvaluation self-hosted:2331
    evaluation self-hosted:2292

This module is used in the browser by libp2p and ipfs, tested in CI

i did not look into browser tests, but i remember having a thought of surprise about that. all browser tests pass in libp2p and in this package, but i am getting errors in the real browser.

[achingbrain]

In clean-stack the os import is replaced with false by the browser key in package.json - how ever you are consuming the code from this module (bundler, etc) may not be respecting browser overrides.

[abetaev]

@achingbrain you are right, i did a little digging...

vite replaces the actual import with that exception while in dev mode. in production mode it replaces it with an empty object.

it is, probably, a matter of taste, but the way vite handles "externalized" modules seems fair to me: if not treated properly in code, they might cause undefined behavior.