This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: use new content and peer routing apis #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/use-new-content-and-peer-routing-apis
branch
8 times, most recently
from
d38c19e to
bea1087
Compare
7 tasks
vasco-santos
force-pushed
the
chore/use-new-content-and-peer-routing-apis
branch
2 times, most recently
from
1566333 to
d2eaeee
Compare
5 tasks
vasco-santos
force-pushed
the
chore/use-new-content-and-peer-routing-apis
branch
3 times, most recently
from
5100466 to
9e4e657
Compare
vasco-santos
force-pushed
the
chore/use-new-content-and-peer-routing-apis
branch
from
9e4e657 to
185f9c5
Compare
jacobheun
suggested changes
Apr 23, 2020
src/message/index.js
Outdated
| id: peer.id.id, | ||
| addrs: peer.multiaddrs.toArray().map((m) => m.buffer) | ||
| addrs: (peer.multiaddrs || []).map((m) => m && m.buffer), |
There was a problem hiding this comment.
What's the reasoning for the check on m (m && m.buffer)? If it's possible for m to be null or undefined we should do a reduce, otherwise we'll end up with undefined in the addrs array for that value.
There was a problem hiding this comment.
It was me when trying to debug a bug to short circuit it. But it is not needed anymore 😆
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR removes thepeer-infofrom being used, as well as returned in the API, in favour of returning{ id, multiaddrs }in the same way as ipfs does. Moreover, it uses the newtopologyinterfaceBREAKING CHANGE: findProviders returns id and addrs properties instead of peer-info instance
This PR sits on top of #179 and #180, and those should be merged first and this PR rebased.
Needs: