Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Lack of good Linux and Windows support when used with Node.js #57

Closed
victorb opened this issue Dec 13, 2016 · 6 comments
Closed

Lack of good Linux and Windows support when used with Node.js #57

victorb opened this issue Dec 13, 2016 · 6 comments
Assignees
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue

Comments

@victorb
Copy link
Member

victorb commented Dec 13, 2016

There is a known issue on Ubuntu machine with node-webrtc, issue here: node-webrtc/node-webrtc#281

Solution currently seems to be building node-webrtc from source, which takes long time and also lots of space. Currently trying out if it helps, will report back.

@victorb
Copy link
Member Author

victorb commented Dec 13, 2016

So, spent around one hour building node-webrtc from source (and about 18gbs...) and ended up getting a segfault instead of the x11 display issue.

Edit: Replacing node_modules/wrtc/build/wrtc/v0.0.61/Release/node-v48-linux-x64/wrtc.node with the artifact from node-webrtc did fix the issue though node-webrtc/build/Release/wrtc.node. Running the binary directly was why I got the seg fault

@daviddias daviddias added status/ready Ready to be worked kind/bug A bug in existing code (including security flaws) labels Dec 18, 2016
@daviddias
Copy link
Member

@victorbjelkholm could you convert this to documentation, please?

@daviddias daviddias changed the title Does not support Ubuntu currently, because of wrtc Lack of good Linux and Windows support when used with Node.js May 17, 2017
@daviddias daviddias added exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue and removed kind/bug A bug in existing code (including security flaws) labels May 17, 2017
@daviddias daviddias added exp/wizard Extensive knowledge (implications, ramifications) required and removed exp/expert Having worked on the specific codebase is important labels Aug 31, 2017
@daviddias
Copy link
Member

daviddias commented Sep 8, 2017

ping @victorbjelkholm.

Could you handle this?

@victorb
Copy link
Member Author

victorb commented Sep 13, 2017

Tried this again with the following versions:

{ 'libp2p-webrtc-star': '0.13.2',
  npm: '5.3.0',
  ares: '1.10.1-DEV',
  http_parser: '2.7.0',
  icu: '57.1',
  modules: '48',
  node: '6.9.0',
  openssl: '1.0.2j',
  uv: '1.9.1',
  v8: '5.1.281.84',
  zlib: '1.2.8' }

On Ubuntu 16.10 and everything now works fine. Seems like since version 0.0.62 of wrtc, they publish binaries for Ubuntu that works fine!

@victorb victorb closed this as completed Sep 13, 2017
@victorb victorb removed the status/ready Ready to be worked label Sep 13, 2017
@daviddias
Copy link
Member

no seg faults?

@victorb
Copy link
Member Author

victorb commented Sep 13, 2017

@diasdavid nope, nada. Seems to be working fine now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

2 participants