Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for crypto.supportedKeys #2415

Closed
TJKoury opened this issue Feb 13, 2024 · 3 comments
Closed

Add documentation for crypto.supportedKeys #2415

TJKoury opened this issue Feb 13, 2024 · 3 comments
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors topic/docs Documentation

Comments

@TJKoury
Copy link
Contributor

TJKoury commented Feb 13, 2024

  • Version:
    1.0.0

  • Platform:
    Linux pop-os 6.2.6-76060206-generic #202303130630168547333822.04~995127e SMP PREEMPT_DYNAMIC Tue M x86_64 x86_64 x86_64 GNU/Linux

  • Subsystem:

crypto

Severity:

Low

Description:

Add documentation for crypto.supportedKeys. Specifically, marshalling and unmarshalling keys.

Steps to reproduce the error:

N/A
@TJKoury TJKoury added the need/triage Needs initial labeling and prioritization label Feb 13, 2024
@achingbrain
Copy link
Member

Thanks for opening this - would you like to open a PR that adds the missing documentation?

@achingbrain achingbrain added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors topic/docs Documentation and removed need/triage Needs initial labeling and prioritization labels Feb 19, 2024
@tabcat
Copy link
Contributor

tabcat commented Oct 3, 2024 •
edited
Loading

I believe this was closed by #2660 . It removed crypto.supportedKeys and added util functions like publicKeyToProtobuf, publicKeyFromProtobuf and others.

@achingbrain
Copy link
Member

Very true, I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors topic/docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @TJKoury @tabcat