Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/gossipsub: Consider feature-gating the metrics support #2923

Open
thomaseizinger opened this issue Sep 21, 2022 · 0 comments · May be fixed by #5711
Open

protocols/gossipsub: Consider feature-gating the metrics support #2923

thomaseizinger opened this issue Sep 21, 2022 · 0 comments · May be fixed by #5711

Comments

@thomaseizinger
Copy link
Contributor

Description

Currently, prometheus-client is a non-optional dependency of libp2p-gossipsub. Change it to an optional dependency, enabled by a feature flag (metrics f.e.)

Motivation

Not all users user the provided metric support. Making it optional reduces the dependency footprint.

Current Implementation

Are you planning to do it yourself in a pull request?

Maybe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gossipsub): feature gate metrics related code drHuangMHT/rust-libp2p
1 participant
@thomaseizinger