Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kad: remove allow_listening handler config #3499

Closed
thomaseizinger opened this issue Feb 23, 2023 · 3 comments
Closed

kad: remove allow_listening handler config #3499

thomaseizinger opened this issue Feb 23, 2023 · 3 comments
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@thomaseizinger
Copy link
Contributor

Originally posted by @mxinden in #3254 (comment)

The allow_listening config option in Kademlia does nothing as it is always set to true. We should remove it.
@chirag-bgh
Copy link
Contributor

Can I take this?

@thomaseizinger
Copy link
Contributor Author

Definitely! :)

@thomaseizinger thomaseizinger added help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Feb 24, 2023
@chirag-bgh chirag-bgh mentioned this issue Feb 24, 2023
Closed
4 tasks
@thomaseizinger
Copy link
Contributor Author

Outdated with the latest kad client/server mode implementation.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kad): remove allow_listening handler config chirag-bgh/rust-libp2p
2 participants
@thomaseizinger @chirag-bgh